revert includeparentblocks flag

[motatoes]

reverting the ignoreIncludeBlocks terragrunt generation flag since it seems to have introduced some regressions

Summary by CodeRabbit

• New Features

  • Enhanced handling of Terragrunt configurations for improved parsing and validation.

• Bug Fixes

  • Improved error handling for missing configuration files, providing clearer feedback.
  • Streamlined dependency resolution process by enforcing stricter rules on configuration files.

• Refactor

  • Simplified function signatures by removing unnecessary parameters related to include blocks.

[coderabbitai]

Walkthrough

The pull request introduces changes across multiple files related to the handling of Terragrunt configurations within the Digger configuration management system. Key modifications include updates to function signatures to accommodate new parameters, enhanced error handling for configuration file retrieval, and the removal of the IgnoreIncludeBlocks parameter from several functions. These changes aim to streamline the parsing and validation processes for project settings, ensuring clearer feedback and stricter adherence to configuration rules.

Changes

File Path	Change Summary
libs/digger_config/digger_config.go	- Updated hydrateDiggerConfigYamlWithTerragrunt to include ignoreIncludeBlocks parameter. - Improved error handling in LoadDiggerConfigYaml. - Refined validation in ValidateDiggerConfigYaml. - Enhanced conflict detection in retrieveConfigFile.
libs/digger_config/terragrunt/atlantis/generate.go	- Removed ignoreIncludeBlocks parameter from getDependencies and createProject functions, simplifying their signatures and internal logic. - Adjusted comments and formatting for clarity.
libs/digger_config/yaml.go	- Removed IgnoreIncludeBlocks field from TerragruntParsingConfig struct, altering parsing configuration options.

Possibly related PRs

• add flag to ignore all external directories per project #1851: The changes in this PR involve modifications to the hydrateDiggerConfigYamlWithTerragrunt function, which is also a focus of the main PR, indicating a direct relationship in how project configurations are processed.

Poem

🐰 In the land of code where bunnies play,
Configs are tidied up, hooray!
No more blocks to ignore, just clear skies,
With better errors, we’ll be wise.
So hop along, let’s parse with glee,
A smoother path for you and me! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 5ae8348 and cd24b5c.

📒 Files selected for processing (3)

• libs/digger_config/digger_config.go (0 hunks)
• libs/digger_config/terragrunt/atlantis/generate.go (10 hunks)
• libs/digger_config/yaml.go (0 hunks)

💤 Files with no reviewable changes (2)

• libs/digger_config/yaml.go
• libs/digger_config/digger_config.go

🔇 Additional comments (4)

libs/digger_config/terragrunt/atlantis/generate.go (4)

Line range hint 316-327: Function signature change looks good

The removal of ignoreIncludeBlocks parameter from createProject is consistent with the architectural change to always process include blocks. The function remains clean and focused.

---

Line range hint 437-510: Function signature change looks good

The removal of ignoreIncludeBlocks parameter from createHclProject is consistent with the architectural change. The function maintains its clarity and purpose.

---

Line range hint 663-729: Function signature change looks good

The removal of ignoreIncludeBlocks parameter from Parse is consistent with the architectural change. The concurrent processing logic remains intact and well-structured.

Also applies to: 788-791

---

121-121: Verify the impact of always processing include blocks

The removal of ignoreIncludeBlocks parameter means that include blocks will always be processed. While this simplifies the code, it could potentially impact existing configurations that relied on ignoring include blocks.

Consider:

1. Adding a migration guide if this is a breaking change
2. Documenting the new behavior in the README

Also applies to: 142-147

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.