Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There may be no Africans translation for trunk #68

Closed
szepeviktor opened this issue Jun 7, 2017 · 7 comments
Closed

There may be no Africans translation for trunk #68

szepeviktor opened this issue Jun 7, 2017 · 7 comments

Comments

@szepeviktor
Copy link
Contributor

szepeviktor commented Jun 7, 2017 •
edited
Loading

This: https://github.com/diggy/polylang-cli/blob/master/features/lang.feature#L17
In action: https://travis-ci.org/diggy/polylang-cli/builds/240548989#L644
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 7, 2017 •
edited
Loading

Maybe I am wrong.
WP trunk (WordPress 4.9-alpha-40877) may have an inconsistent version number

$wp_version = '4.9-alpha-40877';

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 7, 2017 •
edited
Loading

Oh! af.zip

There may be no Africans translation for trunk!!

@diggy
Copy link
Owner

diggy commented Jun 7, 2017

the plot thickens :)

@szepeviktor szepeviktor changed the title Behat fails to replace placeholder under PHP 5.6 There may be no Africans translation for trunk Jun 7, 2017
@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 7, 2017 •
edited
Loading

We could behat --tags '~@skiptrunk' and add @skiptrunk in this test.

@diggy
Copy link
Owner

diggy commented Jun 7, 2017

or pick another language?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Jun 7, 2017 •
edited
Loading

May there's no translation at all for 4.9
See https://translate.wordpress.org/locale/de

@diggy
Copy link
Owner

diggy commented Jun 10, 2017

testing against trunk out of curiosity, but not essential (therefore allowed to fail). Would you mind submitting a PR with the @skiptrunk tag?

This was referenced Jun 10, 2017
Closed
Merged
@diggy diggy closed this as completed in #73 Jun 10, 2017
diggy added a commit that referenced this issue Jun 10, 2017
@diggy
Merge pull request #73 from szepeviktor/patch-3
5163cce 
Skip language tests for trunk, closes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@szepeviktor @diggy