Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert missing source field for S/MIME pkix.smtp_utf8_mailbox_domain_part_invalid_syntax #107

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

robstradling
Copy link
Contributor

Hi @CBonnell. I suspect this was a copy'n'paste error in a recent commit. Do you have any plans to make the columns in the CSV files consistent?

Currently only the S/MIME one has a "source" column...

> find . -iname "*.csv" -print -exec head -n 1 '{}' ';'
./cabf/smime/finding_metadata.csv
severity,code,source,description
./cabf/serverauth/finding_metadata.csv
severity,code,description
./etsi/finding_metadata.csv
severity,code,description

@CBonnell
Copy link
Collaborator

Thanks @robstradling for submitting this patch. I realize the current CSV finding metadata system isn't the greatest. Improving how finding citations/metadata is documented is on the radar for #64.

@CBonnell CBonnell self-requested a review September 11, 2024 19:10
@CBonnell CBonnell merged commit e4bd13b into digicert:main Sep 11, 2024
4 checks passed
@robstradling robstradling deleted the smime_finding_metadata_fix branch September 11, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants