Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add REST API for linting CRLs #113

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Add REST API for linting CRLs #113

merged 2 commits into from
Oct 2, 2024

Conversation

dipaktilekar
Copy link
Contributor

No description provided.

@dipaktilekar dipaktilekar mentioned this pull request Sep 30, 2024
Closed
CBonnell
CBonnell reviewed Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@CBonnell CBonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! I added a few comments requesting minor changes. Let me know if you'd like to discuss.

pkilint/rest/crl.py Outdated Show resolved Hide resolved
tests/test_server.py Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
pkilint/rest/__init__.py Outdated Show resolved Hide resolved
@dipaktilekar
Copy link
Contributor Author

Thanks for this PR! I added a few comments requesting minor changes. Let me know if you'd like to discuss.

Completed review comments, please review again.

@CBonnell CBonnell changed the title 75: REST API for linting CRLs Add REST API for linting CRLs Oct 2, 2024
@CBonnell CBonnell merged commit ebcc1d7 into digicert:main Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBonnell CBonnell CBonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dipaktilekar @CBonnell