Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test leaving a project while offline, then connecting and syncing #584

Closed
EvanHahn opened this issue Apr 25, 2024 · 0 comments · Fixed by #620
Closed

Test leaving a project while offline, then connecting and syncing #584

EvanHahn opened this issue Apr 25, 2024 · 0 comments · Fixed by #620
Assignees
@EvanHahn
Labels
mvp Requirement for MVP

Comments

@EvanHahn
Copy link
Contributor

EvanHahn commented Apr 25, 2024 •
edited
Loading

We don't test what happens when someone leaves a project while offline, then syncs that to others. This test may uncover bugs, which we should fix.
@EvanHahn EvanHahn added the mvp Requirement for MVP label Apr 25, 2024
@EvanHahn EvanHahn mentioned this issue Apr 25, 2024
Merged
@EvanHahn EvanHahn self-assigned this Apr 25, 2024
EvanHahn added a commit that referenced this issue May 7, 2024
@EvanHahn
fix: remove replication error when core is closed
f1958d3 
If a core is closed, we can't replicate it.

This can happen if you leave a project while offline, then reconnect. I
added a test for this case and fixed the issue. (The fix is just one
line, but it took a whole day to figure that out.)

Fixes [#584].

[#584]: #584
@EvanHahn EvanHahn mentioned this issue May 7, 2024
Merged
EvanHahn added a commit that referenced this issue May 9, 2024
@EvanHahn
fix: remove replication error when core is closed
05c6adb 
If a core is closed, we can't replicate it.

This can happen if you leave a project while offline, then reconnect. I
added a test for this case and fixed the issue. (The fix is just one
line, but it took a whole day to figure that out.)

Fixes [#584].

[#584]: #584
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
mvp Requirement for MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove replication error when core is closed digidem/comapeo-core
1 participant
@EvanHahn