Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting "wants" on sync state, rather than the default of "want everything" #682

Closed
EvanHahn opened this issue May 27, 2024 · 1 comment
Closed

Support setting "wants" on sync state, rather than the default of "want everything" #682

EvanHahn opened this issue May 27, 2024 · 1 comment
Assignees
@EvanHahn
Labels
Project: Disk Space Management v1

Comments

@EvanHahn
Copy link
Contributor

EvanHahn commented May 27, 2024 •
edited by gmaclennan
Loading

Sync state should accept bitfields to define "wants". Once a "want" is received for a given core, sync state should no longer assume that the peer wants everything in the core, instead it only wants what is defined in the want bitfield(s).
@EvanHahn EvanHahn self-assigned this Aug 26, 2024
@EvanHahn EvanHahn removed their assignment Oct 10, 2024
@gmaclennan gmaclennan changed the title Change sync state so that it shows sync as completed once selected media has synced with devices that are not syncing everything Support setting "wants" on sync state, rather than the default of "want everything" Oct 17, 2024
@gmaclennan gmaclennan assigned gmaclennan and EvanHahn and unassigned gmaclennan Oct 24, 2024
@EvanHahn EvanHahn mentioned this issue Nov 7, 2024
Merged
@EvanHahn EvanHahn assigned gmaclennan and EvanHahn and unassigned EvanHahn and gmaclennan Nov 7, 2024
EvanHahn added a commit that referenced this issue Nov 20, 2024
@EvanHahn
feat: handle incoming blob filters (#956)
5ae541d 
*You may wish to [review this squashed commit as separate commits][0].*

When you receive a blob filter from another peer, this updates their
sync states. For example, if you receive a blob filter that says "I only
want photo thumbnails", that peer's "wants" bitfield will be reduced.

Closes [#682] and [#905].

[0]: https://github.com/digidem/comapeo-core/pull/956/commits
[#682]: #682
[#905]: #905
@EvanHahn
Copy link
Contributor Author

Done in 3d1c94b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
Project: Disk Space Management v1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmaclennan @EvanHahn