Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update main exports #284

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat: update main exports #284

merged 2 commits into from
Sep 28, 2023

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Sep 26, 2023

Towards #278

Waiting for #283 to be merged since it also includes some relevant changes

Summary of changes (so far):

  • adds MapeoManager to exports
  • removes MapeoProjects from exports

@achou11
Copy link
Member Author

achou11 commented Sep 26, 2023

@gmaclennan anything else that you think should be updated in this PR?

@gmaclennan
Copy link
Member

@gmaclennan anything else that you think should be updated in this PR?

I don't think so. I already did all the work for publishing typescript types, and have done a test publish as a module. It is currently published as @mapeo/core@9.0.0-alpha.0, and only the alpha npm dist tag points to it - the latest dist tag points to v8.6.2 (we should keep it like that for now). To install do npm i @mapeo/core@alpha or use the specific version npm i @mapeo/core@9.0.0-alpha.0

@gmaclennan
Copy link
Member

Maybe remove the MapeoProject export now? Not sure it is needed?

@achou11
Copy link
Member Author

achou11 commented Sep 27, 2023

Maybe remove the MapeoProject export now? Not sure it is needed?

Feel like it'd be useful to keep if we're talking about general usage of this library, but if we're not concerned about that right now then that's okay too

EDIT: guess one could still import the project via import { MapeoProject } from '@mapeo/core/src/mapeo-project.js' right?

@achou11 achou11 changed the title WIP: update this module to be ready for usage as a dep feat: update main exports Sep 27, 2023
@achou11 achou11 requested a review from gmaclennan September 27, 2023 15:35
@achou11 achou11 marked this pull request as ready for review September 27, 2023 15:35
@achou11 achou11 self-assigned this Sep 27, 2023
@achou11 achou11 merged commit 1e0df1c into main Sep 28, 2023
@achou11 achou11 deleted the ac/library-fixes branch September 28, 2023 17:16
gmaclennan added a commit that referenced this pull request Sep 29, 2023
* main:
  feat: update main exports (#284)
  feat: add invite namespace to MapeoManager (#281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants