WIP: send device info on first connect #311
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
As of now:
device-info
events and do anything with thoseQuestions:
does this live at the manager level or project instance level?
what should the manager do when the rpc instance emits a
device-info
event?localDeviceInfo
directorynoticing that the
deviceId
on thedevice-info
payload is referring to a peer id as defined by hypercore secret stream or whatever, butdeviceId
in MapeoManager/MapeoProject refers to a value derived from the keyManager instance's identity keypair. is this intentional? if so, how are we supposed to use thedeviceId
from thedevice-info
event?