Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: send device info on first connect #311

Closed
wants to merge 1 commit into from

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Oct 4, 2023

Closes #245

As of now:

  • only implements sending the device info on initial connection. does not listen for device-info events and do anything with those

Questions:

  • does this live at the manager level or project instance level?

    • initially thought manager but now i'm wondering if this is project-based, because we would have the option to selectively send the device info based on whether we have local knowledge of the connected peer (which lives in the project dbs)
  • what should the manager do when the rpc instance emits a device-info event?

    • are we persisting that info somewhere? e.g. in the localDeviceInfo directory
  • noticing that the deviceId on the device-info payload is referring to a peer id as defined by hypercore secret stream or whatever, but deviceId in MapeoManager/MapeoProject refers to a value derived from the keyManager instance's identity keypair. is this intentional? if so, how are we supposed to use the deviceId from the device-info event?

@achou11
Copy link
Member Author

achou11 commented Oct 4, 2023

Closing because I totally misunderstood the issue and this part is actually blocked on mdns work.

@achou11 achou11 closed this Oct 4, 2023
@achou11 achou11 deleted the 245/device-name-first-connect branch October 4, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send device name over RPC channel
1 participant