Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release workflow configuration #379

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

achou11
Copy link
Member

@achou11 achou11 commented Nov 15, 2023

Fixes #359

Noticed an error about missing a build npm script: https://github.com/digidem/mapeo-core-next/actions/runs/6882793274/job/18722037582#step:3:164

npm ERR! Missing script: "build"

Not entirely sure what the necessary change is, but figured at least removing the step that fails would be a good start.

Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that should fix it. The necessary build step for npm is in the prepack script, which will automatically run when the package is packed for publishing, so removing the line here should just fix it.

@achou11 achou11 merged commit 658da21 into main Nov 16, 2023
7 checks passed
@achou11 achou11 deleted the ac/fix-release-workflow branch November 16, 2023 13:25
gmaclennan added a commit that referenced this pull request Nov 20, 2023
* main:
  chore: pin more hyper deps (#381)
  chore: extract and test construction of icon url (#366)
  chore: fix release workflow configuration (#379)
  chore: remove unused/unneeded deps (#376)
  chore: remove authstore (#377)
  fix: handle duplicate connections to LocalPeers (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow being triggered each time a pull request is merged to main
2 participants