Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: blobstore #62

Merged
merged 24 commits into from
Mar 7, 2023
Merged

feat: blobstore #62

merged 24 commits into from
Mar 7, 2023

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan commented Jan 23, 2023 •
edited
Loading

An initial implementation of a BlobStore, fixes #52

@gmaclennan gmaclennan mentioned this pull request Jan 23, 2023
Merged
@sethvincent sethvincent changed the base branch from mapeo-core-store to main February 8, 2023 22:01
@gmaclennan
Copy link
Member Author

Rebased on main

@gmaclennan gmaclennan marked this pull request as ready for review February 22, 2023 12:22
sethvincent
sethvincent approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@sethvincent sethvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with the invites PR I read through this again and it looks good to me. Excited to merge it and work on integrating everything 👍

@gmaclennan
cleanup tests, change download signature, fixes
3eecfa3 
Added a helper to remove boilerplate in tests
Changed blobStore.download() to accept an optional filter, rather than
a file path, because file paths are not used elsewhere
@gmaclennan
Copy link
Member Author

gmaclennan commented Feb 28, 2023 •
edited
Loading

I read through this again today and did some cleanup and additional tests. Before merging I want to:

Additional tests

Ok for after merge

@sethvincent sethvincent self-requested a review February 28, 2023 21:58
@gmaclennan gmaclennan deleted the feat/blobstore branch August 31, 2023 06:41
This was referenced Nov 16, 2023
Closed
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 4, 2023
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 12, 2023
Merged
@EvanHahn EvanHahn mentioned this pull request Mar 7, 2024
Closed
1 task
@optic-release-automation optic-release-automation bot mentioned this pull request Mar 14, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Apr 30, 2024
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request May 9, 2024
Merged
This was referenced Jun 20, 2024
Merged
Merged
Merged
This was referenced Jul 25, 2024
Merged
Merged
@optic-release-automation optic-release-automation bot mentioned this pull request Aug 13, 2024
Merged
This was referenced Aug 21, 2024
Merged
Merged
This was referenced Aug 29, 2024
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 11, 2024
Closed
Merged
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethvincent sethvincent Awaiting requested review from sethvincent

Assignees
No one assigned
Labels
blobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlobStore
2 participants
@gmaclennan @sethvincent