Skip to content

Commit

Permalink
chore!: make Preset's iconRef optional (#235)
Browse files Browse the repository at this point in the history
This is a partial revert of 4ce47f0.

We shouldn't have made `iconRef` optional on `Preset`s. This reverts
that.
  • Loading branch information
EvanHahn authored Sep 3, 2024
1 parent 9465e62 commit 4dc97dc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion proto/preset/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ message Preset_1 {
map<string, TagValue_1> addTags = 8;
map<string, TagValue_1> removeTags = 9;
repeated FieldRef fieldRefs = 10;
IconRef iconRef = 11;
optional IconRef iconRef = 11;
repeated string terms = 12;
string color = 13;

Expand Down
3 changes: 1 addition & 2 deletions schema/preset/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,7 @@
"fieldRefs",
"schemaName",
"terms",
"color",
"iconRef"
"color"
],
"additionalProperties": false
}

0 comments on commit 4dc97dc

Please sign in to comment.