Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method for resetting index state #26

Closed
achou11 opened this issue Jan 10, 2024 · 0 comments · Fixed by #34
Closed

Add a method for resetting index state #26

achou11 opened this issue Jan 10, 2024 · 0 comments · Fixed by #34
Assignees
@EvanHahn

Comments

@achou11
Copy link
Member

achou11 commented Jan 10, 2024

Relevant for digidem/comapeo-core#241

Leaving a project involves deleting indexed data and this module keeps some internal state about the last indexed version/number. In order to safely delete indexed data, we need to also expose a method in this module that resets the indexing state (e.g. in case a device left and then rejoined a project)
@achou11 achou11 mentioned this issue Jan 10, 2024
Closed
4 tasks
EvanHahn added a commit that referenced this issue Jan 18, 2024
@EvanHahn
feat: add a method for resetting index state
8fc3242 
This adds
`MultiCoreIndexer.prototype.removeCoreAndUnlinkIndexStorage(core)` which
removes the core from the indexer and destroys the storage.

Addresses [issue #26][0].

[0]: #26
@EvanHahn EvanHahn mentioned this issue Jan 18, 2024
Closed
EvanHahn added a commit that referenced this issue Jan 18, 2024
@EvanHahn
feat: add a method for resetting index state
9c70871 
This adds
`MultiCoreIndexer.prototype.removeCoreAndUnlinkIndexStorage(core)` which
removes the core from the indexer and destroys the storage.

Addresses [issue #26][0].

[0]: #26
EvanHahn added a commit that referenced this issue Jan 18, 2024
@EvanHahn
feat: add a method for resetting index state
5b97903 
This adds
`MultiCoreIndexer.prototype.removeCoreAndUnlinkIndexStorage(core)` which
removes the core from the indexer and destroys the storage.

Addresses [issue #26][0].

[0]: #26
@EvanHahn EvanHahn self-assigned this Jan 18, 2024
@EvanHahn EvanHahn linked a pull request Jan 18, 2024 that will close this issue
feat: add a method for resetting index state #31
Closed
EvanHahn added a commit that referenced this issue Jan 19, 2024
@EvanHahn
feat: add method to unlink storage
7d22a0d 
This adds `MultiCoreIndexer.prototype.unlink()` which unlinks all the
index storage.

Addresses #26.
@EvanHahn EvanHahn mentioned this issue Jan 19, 2024
Merged
EvanHahn added a commit that referenced this issue Jan 19, 2024
@EvanHahn
feat: add method to unlink storage
af8c70f 
This adds `MultiCoreIndexer.prototype.unlink()` which unlinks all the
index storage.

Addresses #26.
EvanHahn added a commit that referenced this issue Jan 19, 2024
@EvanHahn
feat: add method to unlink storage
4d8c94a 
This adds `MultiCoreIndexer.prototype.unlink()` which unlinks all the
index storage.

Addresses #26.
EvanHahn added a commit that referenced this issue Jan 19, 2024
@EvanHahn
feat: add method to unlink storage
c150170 
This adds `MultiCoreIndexer.prototype.unlink()` which unlinks all the
index storage.

Addresses #26.
@EvanHahn EvanHahn linked a pull request Jan 22, 2024 that will close this issue
feat: add method to unlink storage #34
Merged
EvanHahn added a commit that referenced this issue Jan 30, 2024
@EvanHahn
feat: add method to unlink storage (#34)
98a0e25 
This adds `MultiCoreIndexer.prototype.unlink()` which unlinks all the
index storage.

Closes #26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EvanHahn EvanHahn

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@EvanHahn @achou11