feat!: discoveryId instead of key for entries #25
+45
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
feat/non-ready-cores
to
feat/initial-indexing-state
November 28, 2023 12:36
|
can you rebase this PR so that it's updated with main? Think Github is including the commits from the PR that this was stacked on, so the diff is much larger 😅 guessing the relevant changes are in 905e2fc, so can review that for now |
achou11
reviewed
Dec 5, 2023
gmaclennan
force-pushed
the
feat/entry-discovery-id
branch
from
905e2fc
to
3ccc387
Compare
|
ok now rebased. I'm going to hold off merging in case we need to make any other bug fixes to this module, because I haven't modified mapeo-core to handle this breaking change yet and we don't want to become blocked by that. |
BREAKING CHANGE: this changes the type of `Entry` to have the core discoveryId (the discovery key as a hex string) instead of the core key. Since our mapeo-core code changed to using the discovery key for version ids, we need to calculate the discovery key for each entry, which has a performance cost (it's a hash operation). This change avoids the need for any hashing when processing entries.
gmaclennan
force-pushed
the
feat/entry-discovery-id
branch
from
3ccc387
to
2537f7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stacked on #24, but we should merge and publish that first, then merge and publish this as a separate version, because the breaking changes will require changes to mapeo-core-next.BREAKING CHANGE: this changes the type of
Entryto have the corediscoveryId (the discovery key as a hex string) instead of the core key.
Since our mapeo-core code changed to using the discovery key for version
ids, we need to calculate the discovery key for each entry, which has a
performance cost (it's a hash operation). This change avoids the need
for any hashing when processing entries.