Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing 'Space' key when editing Playlist toggles play #589

Closed
dermeck opened this issue Mar 9, 2024 · 2 comments
Closed

Pressing 'Space' key when editing Playlist toggles play #589

dermeck opened this issue Mar 9, 2024 · 2 comments
Labels
bug Something isn't working
Milestone
Dopamine 3.0 Prev...

Comments

@dermeck
Copy link
Contributor

dermeck commented Mar 9, 2024

Pressing Space while Creating/Editing Playlist and Playlist Folders should not toggle the play/pause.

I'd be happy to tackle this. There seems to be a check for isInputDialogOpened missing. Although I suggest to check for the input target instead (prevent keyboard controlling the player whenever an input is the target).
@digimezzo
Copy link
Owner

digimezzo commented Mar 9, 2024 •
edited
Loading

@dermeck Please do. I'm open for help on this matter :) Thanks!

dermeck added a commit to dermeck/dopamine that referenced this issue Mar 11, 2024
@dermeck
fix digimezzo#589 prevent toggle play via Space key when typing into …
c208cb0 
…an input
dermeck added a commit to dermeck/dopamine that referenced this issue Mar 11, 2024
@dermeck
fix digimezzo#589 prevent toggle play via Space key when typing into …
0c4cafe 
…an input
@dermeck
Copy link
Contributor Author

dermeck commented Mar 11, 2024

@digimezzo the PR is here #591

I am not sure why it is not linked automatically to the issue. 🤔

@digimezzo digimezzo added the bug Something isn't working label Mar 13, 2024
@digimezzo digimezzo added this to the Dopamine 3.0 Preview 26 milestone Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Dopamine 3.0 Preview 26
Development

No branches or pull requests
2 participants
@dermeck @digimezzo