Fix: In ´ngx-leaflet´ fixed ´addVectorLayer´ method so that the styling is also used of the layer vector layers, while maintaining performance. #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng is also used of the layer vector layers, while maintaining performance.
Fix: In `ngx-leaflet` fixed `addVectorLayer` method so that the styli…
Updating GIS-798
Chore: Updated package-lock.json.
TriangleJuice
requested changes
Jul 2, 2024
packages/ngx-leaflet/src/lib/components/leaflet/leaflet.component.html
Outdated
Show resolved
Hide resolved
TriangleJuice
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
This PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When passing down a vector-based layer, first of all it wouldn't work without importing an external script, also when it would work, then the performance would be terrible and the style of the vector layer wouldn't be used.
What is the new behavior?
When passing down a vector-based layer, first of all it works without importing an external script, the performance would be much better than before and the style of the vector layer would be used.
Does this PR introduce a breaking change?
Other information
https://jira.antwerpen.be/browse/GIS-845