-
Notifications
You must be signed in to change notification settings - Fork 1
Remove spring and jersey dependencies #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11670ba to
d68a2f3
Compare
d68a2f3 to
d56f8ec
Compare
getIssuerDN -> getIssuerX500Principal
Fixing my own 2 years old buggy supposedly quality-of-life enhancements
Fixing wrong use of ContentType.create, which really is a factory method specializd for strings you _know_ is just a MIME-type, and fails if you provide e.g. a content-type with a charset. In summary: ContentType.create(<all valid content type strings>) 👎 ContentType.parse(<all valid content type strings>) 👍 Naming things is hard.
To get rid of that pesky checked URISyntaxException creeping in everywhere.
This really needs some further tidying, but this will work for now since the mess is kept inside the internal part of the library.
runeflobakk
approved these changes
Feb 16, 2023
Remove jcl-over-slf4j (Java Commons Logging over SLF4J), as we have no dependencies requiring commons-logging, and do not need this replacement.
To support newer Maven version.
e85a76f to
9f3e1de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace dependency on Spring and Jersey with new
JaxbMarshallerfrom digipost/signature-api-specification#270 and Apache HttpClient 5.