Finalize v3 #288
Merged
Finalize v3 #288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runeflobakk
force-pushed
the
finalize-v3
branch
from
eb51ec7 to
b1205a2
Compare
haralkvi
approved these changes
Sep 15, 2023
Upgrades maven-jaxb2-plugin from 0.14.0 to 0.15.3. This upgrade broke the current rig for piecing together the XSDs, and Now, while gazing at the ton of increase in glorious XML, you ask yourself: "why is all this worth the upgrade from 0.14 to 0.15?". Well, JAXB gets messy and fragile once you have a non-trivial case, as this is: mixed compilation of third party XSDs together with your own. It would seem that the successful operation of the previous setup may have been a bit accidental. The web of imports, includes, namespacing, catalogs, and what not which is used to express this API schema was not resolved as expected by the updated version of the plugin (JAXB, xjc, etc) and produced duplicates which caused compilation errors. This change is an effort to try to stay a bit ahead of the game, to maybe also be able to upgrade to Jakarta JAXB down the road. This is so-called "modularized XSD compilation" where the third party XSDs we use are compiled separately, and the output of each compilation sted are included as "episodes" in further compilation. This seems to resolve that schemas which were imported by multiple other schemas are now only compiled once.
0.15.3 -> 2.0.9
runeflobakk
force-pushed
the
finalize-v3
branch
from
3cc097f to
0e538a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing touches before a 3.0.0 final release.
Basically getting dependencies and JAXB stuff up to speed with the recent restructuring of the https://github.com/highsource/jaxb-tools.
Also see commit message of c8ba048 for some wall-of-text explaining the rationale for modularizing the JAXB/XJC compilation.