Expand serialization customisation options #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-kaczynski
requested review from
donaldgray,
tomcrane,
griffri and
JackLewis-digirati
JackLewis-digirati
approved these changes
Sep 23, 2024
| @@ -3,6 +3,7 @@ | |||
| <PropertyGroup> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
| <PackageId>iiif-net</PackageId> | |||
| <LangVersion>10.0</LangVersion> | |||
There was a problem hiding this comment.
is it worth pointing out somewhere that the language version is being pinned to 10?
There was a problem hiding this comment.
it's kinda implied by the target framework, can be bumped at some point along with framework when 6 goes out of support. Which is /very/ soon :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows using this package's predetermined
JsonSerializationSettingsby library consumers, as well as overriding it for the library (de)serializers. Additionally allows passing custom (external to the library) types deriving fromResourceBaseto be recognised during deserialization byResourceBaseV3Converter.Change in deserialization converter order is in theory a breaking change, but it didn't seem to work correctly beforehand (as per Donald's comments), so take it as you will.
Other changes are opt-in, i.e. have no effect if you don't actively interact with exposed bits.