-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle TextualBody and PaintingAnnotation with Body array #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove no longer required classes
donaldgray
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, simpler than it seemed at first
src/IIIF/IIIF/Presentation/V3/Annotation/TypeClassifyingAnnotation.cs
Outdated
Show resolved
Hide resolved
donaldgray
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56
Gets
TextualBody
to work correctly withinAnnotation
Additionally, refactors
body
to work with allmotivations
rather than a select couple of motivationsNOTE:
SupplementingAnnotation
andTypeClassifyingAnnotation
have been marked as obsolete due to being replaced in functionality byGeneralAnnotation
, but have been left in for backwards compatibilityFinally, references to Nuget have bee n removed from the build due to this
This was also tested with IIIF Presentation using the following payload: