Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Add validation to release.sh snapshot command, improve check command (#20384)" #20399

Open
wants to merge 1 commit into
base: main-2.x
Choose a base branch
from
Open

Backport "Add validation to release.sh snapshot command, improve check command (#20384)" #20399

wants to merge 1 commit into from
+137 −23

Conversation

dylant-da
Copy link
Contributor

  • Stable versions or RCs must always be made from the correct release line.
  • New snapshots must be made from either the correct release line if one exists or origin/main{-2.x} if one doesn't. For example:
    • a 3.2.0 snapshot must be made from release/3.2.x
    • a 3.3.0 snapshot must be made from main because no release/3.3.x exists as of yet.
    • a 2.9.7 snapshot must be made from release/2.9.x
    • a 2.10.0 snapshot must be made from main-2.x because no release/2.10.x exists as of yet.
  • A commit originating from any other branch must be adhoc.

@dylant-da
Add validation to release.sh snapshot command, improve check command (#…
5e83404 
…20384)

- Stable versions or RCs must always be made from the correct release line.
- New snapshots must be made from either the correct release line if one exists or origin/main{-2.x} if one doesn't.
  For example:
  - a 3.2.0 snapshot must be made from release/3.2.x
  - a 3.3.0 snapshot must be made from main because no release/3.3.x exists as of yet.
  - a 2.9.7 snapshot must be made from release/2.9.x
  - a 2.10.0 snapshot must be made from main-2.x because no release/2.10.x exists as of yet.
- A commit originating from any other branch must be adhoc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlpulley-da carlpulley-da carlpulley-da approved these changes

@paulbrauner-da paulbrauner-da Awaiting requested review from paulbrauner-da

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylant-da @carlpulley-da