-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DPP-334 Manually partition the event table #9394
Conversation
...icipant-integration-api/src/main/resources/db/migration/postgres/V50__Append_only_schema.sql
Outdated
Show resolved
Hide resolved
...icipant-integration-api/src/main/resources/db/migration/postgres/V50__Append_only_schema.sql
Outdated
Show resolved
Hide resolved
...icipant-integration-api/src/main/resources/db/migration/postgres/V50__Append_only_schema.sql
Outdated
Show resolved
Hide resolved
...icipant-integration-api/src/main/resources/db/migration/postgres/V50__Append_only_schema.sql
Show resolved
Hide resolved
f19a66e
to
c7e0c49
Compare
c7e0c49
to
094d6c4
Compare
...cipant-integration-api/src/main/scala/platform/indexer/parallel/RawDBBatchPostgreSQLV1.scala
Outdated
Show resolved
Hide resolved
...t-integration-api/src/main/scala/platform/store/appendonlydao/events/EventsTableDelete.scala
Outdated
Show resolved
Hide resolved
...icipant-integration-api/src/main/resources/db/migration/postgres/V50__Append_only_schema.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rautenrieth-da for this good work! As you said, it is a bit boilerplaty, but it is also simple, which I like. Comments added. Nothing major.
ledger/participant-integration-api/src/main/scala/platform/indexer/parallel/PostgresDAO.scala
Outdated
Show resolved
Hide resolved
...r/participant-integration-api/src/main/scala/platform/indexer/parallel/UpdateToDBDTOV1.scala
Outdated
Show resolved
Hide resolved
6755aa5
to
a10cecf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested in an E2E run with no observed performance impact.
This PR has been created by a script, which is not very smart and does not have all the context. Please do double-check that the version prefix is correct before merging. @remyhaemmerle-da is in charge of this release. Commit log: ``` cf2be78 Support rollback nodes in BlindingInfo (#9445) adde90b KV: do not use "Effects" part of InputsAndEffects (#9433) 75fa86a Additional metrics for mutable contract state cache (#9444) d8c34a4 Rename normalization-related params in the integrity checker config (#9455) e335244 Hash submitters in the deduplication key [DPP-347] (#9417) 43ffa42 Test for duplicate contracts when querying on behalf of multiple parties (#9443) 7644844 Document daml ledger export script (#9446) 3193027 DPP-334 Manually partition the event table (#9394) 14661a8 Clearer variable name for subtype evidence (#9442) 40c85d8 Release v1.13.0-snapshot.20210419.6730.0.8c3a8c04 (#9439) 1cb907c KV: do not use "Inputs" part of InputsAndEffects (#9429) ``` Changelog: ``` - [Integration Kit] - deduplication key will contain hashed submitters instead of concatenated submitters * [Daml export] Refer to the "Ledger Export" chapter under the "Early Access Features" for a description of the new Daml ledger export command. This is an early access feature. ``` CHANGELOG_BEGIN CHANGELOG_END
This PR removes the automatic partitioning of the
participant_events
table in favor of a manual partitioning. This is easier to port to other databases, and removes unnecessary fields from individual partitions.Schema changes
participant_events_divulgence
,participant_events_create
,participant_events_consuming_exercise
, andparticipant_events_non_consuming_exercise
. The individual tables are leaner than before - they don't contain useless fields, and the remaining fields have been madeNOT NULL
where possible.participant_events
that contains exactly the same fields as the previous partitioned table of the same name.Testing
The conformance test tool is now run against the append-only schema on Postgres, using
ledger-on-sql
.Future work
DBDTOV1.Event*
non-optional where applicable.