Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-engineer istanbul code coverage dependencies #14

Open
mattcollier opened this issue May 21, 2021 · 1 comment
Open

Re-engineer istanbul code coverage dependencies #14

mattcollier opened this issue May 21, 2021 · 1 comment

Comments

@mattcollier
Copy link
Contributor

The instanbul code coverage libraries used here are not being maintained properly. In particular, there is a JS parser module used to instrument code that is now a number of major releases behind. There are some bugs in the version of the library being used that results in valid JS code not being parsed properly. This will result in webpack failing to build the browser bundle. In cases where this is a problem, I have created this branch that disables the istanbul code coverage.

d00f7ce

Here's a link to the unmaintained library that needs to be replaced somehow:

webpack-contrib/istanbul-instrumenter-loader#96

@aljones15
Copy link

any idea when this will hit a release? This caused issues for me today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants