Support ed25519 2020 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcollier
requested changes
Apr 28, 2021
|
Edit: It showed up now. |
- Update bedrock-veres-one-context and bedrock-did-io.
mattcollier
approved these changes
May 19, 2021
ProfileManager.js
Outdated
Comment on lines
1150
to
1151
| return CapabilityAgent.fromSecret({ | ||
| secret, handle, keyType: 'Ed25519VerificationKey2020'}); |
There was a problem hiding this comment.
Suggested change
| return CapabilityAgent.fromSecret({ | |
| secret, handle, keyType: 'Ed25519VerificationKey2020'}); | |
| return CapabilityAgent.fromSecret({ | |
| secret, handle, keyType: 'Ed25519VerificationKey2020' | |
| }); |
There was a problem hiding this comment.
Fixed here b15d5df
- Remove unused dep and add missing dep in test.
mattcollier
reviewed
May 21, 2021
utils.js
Outdated
Comment on lines
270
to
278
| if(signer.type === 'Ed25519VerificationKey2018') { | ||
| suite = new Ed25519Signature2018({ | ||
| signer, | ||
| }); | ||
| } else if(signer.type === 'Ed25519VerificationKey2020') { | ||
| suite = new Ed25519Signature2020({ | ||
| signer, | ||
| }); | ||
| } |
There was a problem hiding this comment.
I just noticed, that we should throw an error if we hit the bottom without finding a matching signer.type.
|
tracking: digitalbazaar/bedrock-karma#14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Some tests has been skipped since the documentLoader currently doesn't have did:v1 resolver added to it yet. All those tests pass though when I change the didMethod from v1 to key.So whenever veres one resolver gets added to the documentLoader, these tests can be unskipped.
Update: All tests are passing now and documentLoader has been updated.