Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use ed25519 2020 #77

Merged
merged 20 commits into from
May 21, 2021
Merged

Update to use ed25519 2020 #77

merged 20 commits into from
May 21, 2021

Conversation

JSAssassin
Copy link
Contributor

No description provided.

mattcollier
mattcollier reviewed Apr 26, 2021
View reviewed changes
lib/helpers.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2021 •
edited
Loading

Codecov Report

Merging #77 (90f69aa) into master (8d58d98) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   81.84%   81.89%   +0.04%     
==========================================
  Files           7        7              
  Lines         595      591       -4     
==========================================
- Hits          487      484       -3     
+ Misses        108      107       -1
Impacted Files Coverage Δ
schemas/bedrock-edv-storage.js 100.00% <ø> (ø)
lib/helpers.js 75.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ea3964...90f69aa. Read the comment docs.

@JSAssassin JSAssassin marked this pull request as ready for review April 27, 2021 14:07
dlongley
dlongley approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, AFAICT.

dmitrizagidulin
dmitrizagidulin approved these changes Apr 28, 2021
View reviewed changes
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattcollier
Copy link
Contributor

mattcollier commented May 4, 2021 •
edited by JSAssassin
Loading

Waiting on:

@mattcollier mattcollier mentioned this pull request May 4, 2021
Merged
@JSAssassin JSAssassin mentioned this pull request May 5, 2021
Merged
@mattcollier mattcollier merged commit d1ba0d0 into master May 21, 2021
@mattcollier mattcollier deleted the update-to-use-ed25519-2020 branch May 21, 2021 13:22
@JSAssassin JSAssassin mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@mattcollier mattcollier mattcollier approved these changes

@dmitrizagidulin dmitrizagidulin dmitrizagidulin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JSAssassin @codecov-commenter @mattcollier @dlongley @dmitrizagidulin