Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for multiple signature suite #68

Merged
merged 41 commits into from
May 21, 2021
Merged

Support for multiple signature suite #68

merged 41 commits into from
May 21, 2021

Conversation

JSAssassin
Copy link
Contributor

No description provided.

@mattcollier mattcollier self-assigned this Apr 26, 2021
@mattcollier
Copy link
Contributor

I'm going to work on updating test deps here.

@mattcollier mattcollier force-pushed the support-for-multiple-signature-suite branch from 85f16f4 to f16ad79 Compare April 26, 2021 14:23
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021 •
edited
Loading

Codecov Report

Merging #68 (9dd10cf) into main (403a07b) will increase coverage by 0.33%.
The diff coverage is 74.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   70.22%   70.55%   +0.33%     
==========================================
  Files           7        8       +1     
  Lines         356      377      +21     
==========================================
+ Hits          250      266      +16     
- Misses        106      111       +5
Impacted Files Coverage Δ
lib/config.js 100.00% <ø> (ø)
lib/index.js 100.00% <ø> (ø)
lib/profiles.js 100.00% <ø> (ø)
lib/kms.js 53.84% <20.00%> (-2.57%) ⬇️
lib/profileAgents.js 81.11% <60.00%> (ø)
lib/documentLoader.js 71.42% <71.42%> (ø)
lib/zcaps.js 41.66% <81.25%> (+3.73%) ⬆️
lib/utils.js 95.45% <100.00%> (+1.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403a07b...9dd10cf. Read the comment docs.

@mattcollier
Copy link
Contributor

@JSAssassin Test suite is green here. Turning this back over to you to integrate latest bedrock-edv-storage.

@JSAssassin JSAssassin marked this pull request as ready for review April 27, 2021 14:05
@JSAssassin JSAssassin force-pushed the support-for-multiple-signature-suite branch from 211373b to 59bb4e4 Compare April 28, 2021 13:20
dmitrizagidulin
dmitrizagidulin reviewed May 4, 2021
View reviewed changes
package.json Outdated Show resolved Hide resolved
dmitrizagidulin
dmitrizagidulin approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mattcollier
Copy link
Contributor

mattcollier commented May 4, 2021 •
edited by JSAssassin
Loading

Waiting on:

@JSAssassin JSAssassin mentioned this pull request May 5, 2021
Merged
@JSAssassin JSAssassin force-pushed the support-for-multiple-signature-suite branch from b0776f9 to 69ce7f8 Compare May 10, 2021 18:04
mattcollier
mattcollier approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@mattcollier mattcollier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY.

@mattcollier mattcollier merged commit df97391 into main May 21, 2021
@mattcollier mattcollier deleted the support-for-multiple-signature-suite branch May 21, 2021 14:11
@JSAssassin JSAssassin mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gannan08 gannan08 gannan08 left review comments

@dlongley dlongley dlongley approved these changes

@mattcollier mattcollier mattcollier approved these changes

@dmitrizagidulin dmitrizagidulin dmitrizagidulin approved these changes

Assignees

@JSAssassin JSAssassin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JSAssassin @mattcollier @codecov-commenter @dlongley @dmitrizagidulin @gannan08