Refactor cryptoLd driver to use fromKeyDocument. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrizagidulin
requested review from
dlongley,
gannan08,
JSAssassin and
mattcollier
dmitrizagidulin
force-pushed
the
fromKeyDocument
branch
from
0948b53
to
1e69eaf
Compare
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
- Coverage 92.18% 85.50% -6.69%
==========================================
Files 3 3
Lines 64 69 +5
==========================================
Hits 59 59
- Misses 5 10 +5
Continue to review full report at Codecov.
|
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
Co-authored-by: Dave Longley <dlongley@digitalbazaar.com>
mattcollier
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
cryptoLd.from()now routes tofromKeyDocumenton "untrusted" key objects (ones that contain a@context).