Fix for issue #602. Chrome's window.crypto property is read-only, so …

[ben-yocum]

…when Electron tries to require Node's crypto library, it fails. The fix is identical to that for node-webkit.

[mattcollier]

Thank you for the PR. I think this logic probably belongs in the isNodejs utility here:

https://github.com/digitalbazaar/forge/blob/master/lib/util.js#L110-L111

[ben-yocum]

@mattcollier Sounds fine to me. PR updated.

[mattcollier]

@gitsage it's my understanding that Electron provides two contexts where you main run code. The main process and a renderer process. The main process can load the node crypto module according to this comment.

This article claims the full node API is available in the main process.

I suspect the difficulty here is in the renderer process which does not include the full Node API?

Does forge function properly in one execution context and not in the other? If so, does this patch properly discern between the two?

[ben-yocum]

@mattcollier I have investigated and you are correct, the main process can load the node crypto module correctly. The renderer process cannot.

The process of moving node-forge into the main thread was a pretty big pain. You have to perform asynchronous communication with the main thread through ICP, which carries a performance hit with it.

I think this PR should be closed without merging. Those who need this behavior should use the existing usePureJavaScript flag.

[mattcollier]

@gitsage thanks for the follow-up. Closing.