Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure VM ID is a string in ControllerProofPurpose. #183

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

dlongley
Copy link
Member

@dlongley dlongley commented Oct 3, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 13.39%. Comparing base (fdaad31) to head (b060a3c).

Files with missing lines Patch % Lines
lib/purposes/ControllerProofPurpose.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #183      +/-   ##
==========================================
- Coverage   13.45%   13.39%   -0.07%     
==========================================
  Files          16       16              
  Lines         446      448       +2     
==========================================
  Hits           60       60              
- Misses        386      388       +2     
Files with missing lines Coverage Δ
lib/purposes/ControllerProofPurpose.js 14.63% <0.00%> (-0.76%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdaad31...b060a3c. Read the comment docs.

@dlongley dlongley merged commit 3284c15 into main Oct 3, 2024
5 checks passed
@dlongley dlongley deleted the ensure-vm-id branch October 3, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants