Fix @graph @container term @context handling.
#544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a term scoped context is nullified, it also nullifies the container information. This fix gets the `@container` value from the active context. In particular, this is needed for proper `@graph` container handling.
BigBlueHat
approved these changes
Dec 6, 2023
dlongley
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a term scoped context is nullified, it also nullifies the container information. This fix gets the
@containervalue from the active context. In particular, this is needed for proper@graphcontainer handling.It is a bit difficult to reason about the correctness of this fix. All test suite tests including the additional one related to this issue pass. But more esoteric untested JSON-LD structures may not?
w3c/json-ld-api#582
w3c/vc-data-model#1373