Remove install for rdf-canonize-native. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add that we need to get this fixed up so that we can make a release with a bumped node-forge dep. |
|
+1 for dropping node 6 and 8 support. |
|
I don't understand the consequences of removing the native package install. Is that being adequately tested some other way? Don't we need that for integration testing? |
|
Created issue for fixing rdf-canonize-native: digitalbazaar/rdf-canonize-native#9 |
|
Created an issue for re-enabling integration testing: #33 |
dlongley
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves rdf-canonize-native build failures on node 12 and 14 as shown here: https://travis-ci.org/github/digitalbazaar/rdf-canonize/builds/731728025
However, node6 is failing because evidently an es6 spread operator has slipped in where it should not be. (see failed CI on this PR).
So, someone who knows how this test suite works with node6 can fix that, or we can drop node6 support all together. Probably in that case we would/should drop 6 and 8.