Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vc 2.0 Style nit: ensure credentials includes version. #181

Merged
merged 4 commits into from
Jul 6, 2024

Conversation

aljones15
Copy link
Contributor

just makes the imports of the credentials context each contain a version to remove ambiguity between which context each import refers to.

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (c22021f) to head (f329f8e).

Additional details and impacted files
@@              Coverage Diff               @@
##           update-vc-2.0     #181   +/-   ##
==============================================
  Coverage          90.46%   90.46%           
==============================================
  Files                  5        5           
  Lines               1059     1059           
==============================================
  Hits                 958      958           
  Misses               101      101           
Files Coverage Δ
lib/contexts/index.js 100.00% <100.00%> (ø)
lib/helpers.js 92.39% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c22021f...f329f8e. Read the comment docs.

@aljones15 aljones15 self-assigned this Jul 5, 2024
@aljones15 aljones15 requested a review from BigBlueHat July 5, 2024 14:43
@aljones15 aljones15 marked this pull request as ready for review July 5, 2024 14:44
@aljones15 aljones15 requested review from davidlehn and dlongley July 5, 2024 14:44
@aljones15 aljones15 changed the title Style nit: ensure credentials includes version. Vc 2.0 Style nit: ensure credentials includes version. Jul 5, 2024
@aljones15 aljones15 removed the request for review from davidlehn July 5, 2024 14:45
Copy link
Member

@dlongley dlongley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems ok to me.

@dlongley dlongley merged commit 203d698 into update-vc-2.0 Jul 6, 2024
5 checks passed
@dlongley dlongley deleted the vc-2.0-context-var-includes-version branch July 6, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants