Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgnoredPackages does not work #42

Closed
dermeister0 opened this issue Nov 7, 2020 · 3 comments
Closed

IgnoredPackages does not work #42

dermeister0 opened this issue Nov 7, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@dermeister0
Copy link

Describe the bug
The tool does not exclude the listed packages.

To Reproduce
Steps to reproduce the behavior:

    "IgnoredPackages": [
      {
        "Id": "NugetDefense",
        "Version": "1.0.8.0"
      },
      {
        "Id": "NLog",
        "Version": "4.7.5"
      }
    ],

or

    "IgnoredPackages": [
      {
        "Id": "NugetDefense",
        "Version": "1.0.8.0"
      },
      {
        "Id": "NLog"
      }
    ],
error : 1 vulnerabilities found for NLog @ 4.7.5

Expected behavior
The package should be ignored.

Screenshots
If applicable, add screenshots to help explain your problem.

Tools (please complete the following information):

  • IDE: VS2019
  • OS: Windows 10 Update 2004

Additional context
The IgnoredPackages property is not used at all.

@dermeister0 dermeister0 added the bug Something isn't working label Nov 7, 2020
@digitalcoyote
Copy link
Owner

I'm looking to do a release tomorrow. I'll try to get this fixed by then. I felt something looked off in that, but I didn't have a scenario where I wanted to ignore s package to test with.

I'll be adding a test for this as well.

digitalcoyote added a commit that referenced this issue Nov 7, 2020
@digitalcoyote
Copy link
Owner

digitalcoyote commented Nov 7, 2020

1.0.14-pre0001 should be published soon and contains a fix for this, I'm going to try to squeeze in one more issue before the final release

Edit: I'm getting an interesting error after packing this (System.MissingMethodException) I'm in the process ofsetting up a new dev environment to try and remedy it. If this fails, I'm going to try to manually update the corrupted DLL in the nupkg. I've delisted the pre-release since it was unusable.

@digitalcoyote digitalcoyote self-assigned this Nov 7, 2020
@digitalcoyote
Copy link
Owner

Should be fixed in v1.0.14. I encourage you to reopen this if this build does not fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants