Guards against creating very large UImages from SVGs

Fixes openhab#817 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
digitaldan · Sep 14, 2024 · fa29577 · fa29577
1 parent a0b2c22
commit fa29577
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/openHAB/OpenHABSitemapViewController.swift b/openHAB/OpenHABSitemapViewController.swift
@@ -46,6 +46,9 @@ struct OpenHABImageProcessor: ImageProcessor {
  let svgkSourceNSData = SVGKSourceNSData.source(from: data, urlForRelativeLinks: nil)
  let parseResults = SVGKParser.parseSource(usingDefaultSVGKParser: svgkSourceNSData)
  if parseResults?.parsedDocument != nil, let image = SVGKImage(parsedSVG: parseResults, from: svgkSourceNSData), image.hasSize() {
+ if image.size.width > 1000 || image.size.height > 1000 {
+ return UIImage(named: "error.png") // Avoid too-large images which cause memory issues
+ }
  return image.uiImage
  } else {
  return UIImage(named: "error.png")