-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve room power level handling #5
Comments
Relevant matrix-doc issue https://github.com/matrix-org/matrix-doc/issues/3724 |
Per https://github.com/matrix-org/matrix-doc/issues/3724#issuecomment-1038391593 it seems that there is no hard cap except the maximum allowable integer by canonical json. That's reassuring, but doesn't prevent servers to enforce the cap of 100 (the highest value mentioned by the spec). |
Federation with an account on matrix.org tested. No issues, power levels propagate correctly. |
Does Synapse not validate these power level values? Is
150
a valid value? Them.room.power_levels
description in the Matrix 1.2 spec does not seem to explicitly state that you can't use a value higher than100
.In practice, it seems like you've tested it and Synapse and the clients you've tested don't break, at least not yet.
Still, it seems a little dangerous to use such values. Any homeserver that gets involved with this room over federation may encounter trouble. Even Synapse itself may reject this unusual value if it encounters it over federation (not tested, but it's a reasonable suspicion).
So I think that this feature is a little dangerous to have, especially when enabled by default.
It may make sense to:
100
?m.room.encryption
down to100
or lower, once you've set it to a value than your own power level)matrix_encyption_disabler
is active are forever prevented from becoming encryptedOriginally posted by @spantaleev in #4 (comment)
The text was updated successfully, but these errors were encountered: