Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow MT only when user has publish_page right #2961

Open
MizukiTemma opened this issue Aug 2, 2024 · 6 comments · May be fixed by #3367
Open

Allow MT only when user has publish_page right #2961

MizukiTemma opened this issue Aug 2, 2024 · 6 comments · May be fixed by #3367
Assignees
@jonbulz
Labels
bug Something isn't working prio: medium Should be scheduled in the forseeable future.
Milestone
Next-up

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Aug 2, 2024 •
edited
Loading

Describe the Bug

Author is an user role with no publishing right that can only save pages for review. Currently users with role author can automatically traslate pages. That means, users who cannot finalize pages can translate. This does not make sense (if a page is not approved, it must be changed and trasnlated again). MT should be available only when the user has publish_page right.

Steps to Reproduce

  1. Log in as an author user
  2. Go to a page
  3. See you can neither save as draft nor publish the page but translate by MT.

Expected Behavior

MT is available only if the user can publish the page

Actual Behavior

MT is available even if the user can only submit for review

Additional Information

This "submit for review" feature exists only for pages.
MT should be available also for author users, if they are either listed as editor (page base right) or a member of the organization responsible for the page (access per organization membership).

For a suggested solution see here

Traceback
@MizukiTemma MizukiTemma added the bug Something isn't working label Aug 2, 2024
@osmers osmers added the prio: medium Should be scheduled in the forseeable future. label Aug 2, 2024
@osmers osmers added this to the 24Q3 milestone Aug 2, 2024
@MizukiTemma MizukiTemma self-assigned this Aug 2, 2024
@MizukiTemma
Copy link
Member Author

@osmers
Should bulk MT be available for authors and observers?

@osmers
Copy link

osmers commented Aug 5, 2024

@MizukiTemma no, imo it shouldn't bcs again they cannot publish, so why should they be able to translate....

@MizukiTemma
Copy link
Member Author

@osmers
Sorry, I wanted mean the case when an user can publish certain pages but not all the pages.
Deactivate the bulk MT for them completely, or allow when there is at least one page they can publish?

@osmers
Copy link

osmers commented Aug 7, 2024

@MizukiTemma yeah, either deactivate it completely or throw an error saying "you selected pages you are not allowed to publish for translation" when they choose pages they are not assigned to as a Redakteur.

@MizukiTemma MizukiTemma mentioned this issue Aug 14, 2024
Closed
@MizukiTemma MizukiTemma removed their assignment Sep 2, 2024
@osmers osmers modified the milestones: 24Q3, 24Q4 Oct 2, 2024
@charludo charludo self-assigned this Nov 7, 2024
@charludo charludo removed their assignment Dec 9, 2024
@JoeyStk JoeyStk removed this from the 24Q4 milestone Dec 14, 2024
@JoeyStk JoeyStk added this to the Next-up milestone Jan 14, 2025
@jonbulz
Copy link
Contributor

jonbulz commented Jan 15, 2025

@MizukiTemma @charludo I think I'd like to take a closer look on this one, since it already has a solution outlined in the closed PR. Or is someone already working on it?

@MizukiTemma
Copy link
Member Author

@MizukiTemma @charludo I think I'd like to take a closer look on this one, since it already has a solution outlined in the closed PR. Or is someone already working on it?

I don't think this issue is being aktively worked on right now.

@jonbulz jonbulz self-assigned this Jan 15, 2025
@jonbulz jonbulz linked a pull request Jan 27, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonbulz jonbulz

Labels
bug Something isn't working prio: medium Should be scheduled in the forseeable future.
Projects
None yet
Milestone
Next-up
5 participants
@charludo @osmers @JoeyStk @MizukiTemma @jonbulz