only show MT-button if user has publish rights for a page

[jonbulz]

Short description

Show MT-button for pages only to users with publishing rights

Proposed changes

• add additional check user_has_publish_rights in PageTranslationForm and return an empty queryset if they don't

Side effects

• requires changes in some tests, because the AUTHOR role can now only use machine translations for specific pages

Resolved issues

Fixes: #2961

---

Pull Request Review Guidelines

[jonbulz]

Hi @MizukiTemma , I'm a bit lost as to why the tests are failing. I suspect it's because the message I am checking in the logs is the wrong message, but I'm not sure what to expect instead. Can you help me with that?

[MizukiTemma]

@jonbulz
It's probably because of no permission/role check on python side. The buttons for translation is hidden, but the related functions are not checking the permission before translating by MT provider. In GUI author users do not see the MT option and therefore cannot use it. But in the test we call the functions directly, which means author users are not blocked by "hidden" buttons.

[jonbulz]

@MizukiTemma thanks, I see now. Since I don't change any actual permissions, the behavior in tests basically stays the same. I'll have to think about this, I don't think it's very clean. At the very least, I would like to have a test that investigates the expected user experience for authors

[jonbulz]

@MizukiTemma I tried implementing a test to check if the button is visible for observers without publish rights. However, it seems that my approach is not working. Are you doing something similar somewhere else in the code?

[MizukiTemma]

@jonbulz
Hmm, I don't have examples with buttons, but here is an example of test checking whether a certain thins is shown.

[jonbulz]

@MizukiTemma thanks! This is similar to what I have tried, though. I'm afraid that the part of the page I want to check is rendered later, because it never showed up in the response content. Maybe I should bring it up in the next weekly?

[JoeyStk]

Thank you a lot for tackling this issue 🚀 For the page view it works as expected :)
I have one question: Do we also want to hide the translation bulk action in page tree? (maybe this is a question for @osmers?)

[MizukiTemma]

@MizukiTemma thanks! This is similar to what I have tried, though. I'm afraid that the part of the page I want to check is rendered later, because it never showed up in the response content. Maybe I should bring it up in the next weekly?

Sure. Alternatively you can pop this discussion in one of our channels. It helps us to share the context before the weekly and someone may answer quicker.