Add translation coverage row to dashboard #3129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have a reason why you choose a different approach then |
Ah sorry, I overlooked the point about AJAX |
jarlhengstmengel
requested changes
Nov 13, 2024
JoeyStk
force-pushed
the
feature/add-translation-coverage-row-to-dashboard
branch
from
201d766 to
0c35cb1
Compare
jarlhengstmengel
requested changes
Nov 25, 2024
charludo
approved these changes
Dec 6, 2024
JoeyStk
force-pushed
the
feature/add-translation-coverage-row-to-dashboard
branch
from
40b30ce to
a5ca153
Compare
JoeyStk
force-pushed
the
feature/add-translation-coverage-row-to-dashboard
branch
from
a5ca153 to
1de6db4
Compare
|
@jarlhengstmengel I think this PR is ready for review again :) |
|
There are still a few inconsistencies in the data. Therefore @jarlhengstmengel and I will do some more testing and that's why I converted this to a draft PR |
|
@jarlhengstmengel I refactored the calculation for the translation coverage and now I get the correct calculations for the translation_count. Could you please check if it also works for you? :) |
jarlhengstmengel
approved these changes
Jan 20, 2025
JoeyStk
force-pushed
the
feature/add-translation-coverage-row-to-dashboard
branch
from
f3a4b77 to
87c6469
Compare
JoeyStk
force-pushed
the
feature/add-translation-coverage-row-to-dashboard
branch
from
87c6469 to
f39f605
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the translation coverage row to the dashboard. This branch is already quite old and needs a bit of an update, however I finally wanted to open up this PR to get some feedback in advance
Proposed changes
Side effects
Uff... the calculation doesn't seem great. Is someone aware of a better way to do it?Resolved issues
Fixes: #4
Pull Request Review Guidelines