Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate legend for statistics charts #3170

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Nov 4, 2024

Short description

Remove the legend at the top of the chart, replacing it with a box in the right-hand column, as shown in the design proposal in preparation of #1097.

Proposed changes

  • remove old legend
  • generate new legend server-side, using jinja
  • wire them together using the method recommended in the docs for chart.js

Side effects

  • none

Resolved issues

Fixes: #3133


Pull Request Review Guidelines

@charludo charludo linked an issue Nov 4, 2024 that may be closed by this pull request
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you very much! Looks very good :)

Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! ❤️ Everything looks good except this space on the screenshot below between the flag and the language name. I tested it on Chrome Version 130.0.6723.58 and Firefox version 124
image

@JoeyStk
Copy link
Contributor

JoeyStk commented Nov 5, 2024

Ah, one other thing: Since this builds on an already existing feature and is going to be a change that municipalities might notice, a release note could make sense? @osmers What do you think? :)

@osmers
Copy link

osmers commented Nov 6, 2024

@JoeyStk yes, I think a release note would make sense :)

@charludo
Copy link
Contributor Author

charludo commented Nov 6, 2024

Thank you for this PR! ❤️ Everything looks good except this space on the screenshot below between the flag and the language name. I tested it on Chrome Version 130.0.6723.58 and Firefox version 124 image

Good point. Currently that sapce is reserved for the second language flag, but you are right, if no language has two flags enabled, it looks weird. Will fix.

@charludo
Copy link
Contributor Author

charludo commented Nov 6, 2024

Ah, one other thing: Since this builds on an already existing feature and is going to be a change that municipalities might notice, a release note could make sense? @osmers What do you think? :)

Ah right, forgot to add it! Thanks!

@charludo charludo force-pushed the enhancement/separate-language-box-for-statistics branch from 1d3c1cc to 39a2b38 Compare November 6, 2024 07:43
@charludo charludo requested review from JoeyStk and lunars97 November 6, 2024 07:44
Copy link
Contributor

@lunars97 lunars97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! 🚀

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you :)

@charludo charludo merged commit eb8cf38 into develop Nov 7, 2024
5 checks passed
@charludo charludo deleted the enhancement/separate-language-box-for-statistics branch November 7, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024-12-18] Add language selection box to statistics
4 participants