Revert "Fix news_id to be number type" #3403
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterNerlich
added
bug
PeterNerlich
requested review from
charludo,
JoeyStk,
MizukiTemma and
jonbulz
jonbulz
approved these changes
Feb 5, 2025
|
Ping to @lunars97 if you have missed the discussion so far :) |
JoeyStk
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert #3382, which changed the type of a value in
datafrom string to intGoogle FCM Services only allow specifying data as key-value pairs that are strictly strings; the app has to parse data received by this third party on its own, where necessary.
Related conversation: https://chat.tuerantuer.org/digitalfabrik/pl/9aw91d3m5td3jm6c34pfpwoxzr