send_push_notifications: 1–based counting, improve messages #3404
+11
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Our `send_push_notifications` management command is giving confusing output.
Successfully sent COUNT/TOTAL
–messages are off by one, as we just usefor count, pn in enumerate(pns):
(0–based).Additionally, I have ideas how to further improve the messages.
Proposed changes
This removes uncertainty while interpreting logs.
This improves readability of logs, as object representations can be very long and wrap multiple lines. With this change first the event/action is clear (length fixed and easily readable even with many similar log lines), then specifics about the object in question can be read (highly variable character count)
PushNotification
andPushNotificationTranslation
title
) quoted, not verbatimThis improves readability as the start and end of the field in the representation is clearly recognizable.
Side effects
Pull Request Review Guidelines