Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components nesting #128

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Components nesting #128

merged 3 commits into from
Mar 22, 2021

Conversation

anna-yeshtukova
Copy link
Contributor

No description provided.

@anna-yeshtukova anna-yeshtukova requested a review from cdbenj March 8, 2021 22:47
@bchiong
Copy link

bchiong commented Mar 9, 2021 •
edited
Loading

Hi Anna,
Looking good overall. Just found issues on the :visitead and mouse down states
Screen Shot 2021-03-09 at 3 38 11 pm
Screen Shot 2021-03-09 at 3 44 23 pm (2)

@anna-yeshtukova
Copy link
Contributor Author

Looking good overall. Just found issues on the :visitead and mouse down states

@cdbenj I have fixed both issues. Can you please review again?

cdbenj
cdbenj approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@cdbenj cdbenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdbenj cdbenj merged commit d1566d5 into master Mar 22, 2021
@cdbenj cdbenj deleted the feature/components-nesting branch March 22, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdbenj cdbenj cdbenj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anna-yeshtukova @bchiong @cdbenj