Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds aria-label values for key CTAs on Map templates #462

Merged
merged 5 commits into from
Oct 11, 2024
Merged

Adds aria-label values for key CTAs on Map templates #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4fe5138
Adds aria-label values for key CTAs on Map templates
oisa Oct 3, 2024
8299eab
Updates video content on the video media item
oisa Oct 11, 2024
491a500
Fixes missing search icon
oisa Oct 11, 2024
73bdc5b
Updates button type attribute location
oisa Oct 11, 2024
b8b20cb
Button type attribute formatting
oisa Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/media/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ meta-index: true
<h3>Full width video</h3>
{{#>_docs-example}}
{{>_media
video="https://www.youtube.com/embed/HNHu2zRPSB4"
title="Digital.nsw launch with Victor Dominello MP at NSW Parliament House"
video="https://player.vimeo.com/video/1011852145?h=05c2a783cc&app_id=122963"
title="NSW Digital Strategy introduction video"
caption="A long caption, ee mei labores adipiscing, nonumy reprehendunt ex mea umo tota has at, clita bonorum erroribus vis ne."
}}
{{/_docs-example}}
Expand Down
8 changes: 4 additions & 4 deletions src/templates/map/equal-filters.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@ model:
<label class="nsw-form__label" for="form-postcode">Search by postcode</label>
<div class="nsw-form__input-group nsw-form__input-group--icon">
<input class="nsw-form__input" type="text" id="form-postcode" name="postcode" value="">
<button class="nsw-button nsw-button--dark nsw-button--flex" type="submit"><span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">search</span></button>
<button type="submit" class="nsw-button nsw-button--dark nsw-button--flex" aria-label="Search for address by postcode"><span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">search</span></button>
</div>
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs">
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs" aria-label="Use my current location">
<span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">near_me</span>
<span>Use my currrent location</span>
</a>
Expand All @@ -109,8 +109,8 @@ model:
</div>
<div class="nsw-col nsw-col-lg-4">
<div class="nsw-map-controls">
<button type="submit" class="nsw-button nsw-button--dark nsw-button--full-width">Search</button>
<button type="reset" class="nsw-link nsw-link--button">Clear all filters</button>
<button type="submit" class="nsw-button nsw-button--dark nsw-button--full-width" aria-label="Search the site with search criteria">Search</button>
<button type="reset" class="nsw-link nsw-link--button" aria-label="Clear all filters">Clear all filters</button>
</div>
</div>
</div>
Expand Down
12 changes: 6 additions & 6 deletions src/templates/map/location-filters.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@ model:
<label class="nsw-form__label" for="form-postcode">Search by postcode</label>
<div class="nsw-form__input-group">
<input class="nsw-form__input" type="text" id="form-postcode" name="postcode" value="">
<button class="nsw-button nsw-button--dark nsw-button--flex" type="submit">Search</button>
<button type="submit" class="nsw-button nsw-button--dark nsw-button--flex" aria-label="Search for address by postcode">Search</button>
</div>
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs">
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs" aria-label="Use my current location">
<span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">near_me</span>
<span>Use my current location</span>
</a>
Expand All @@ -96,7 +96,7 @@ model:
<div class="nsw-layout">
<div class="nsw-layout__sidebar">
<div class="nsw-filters nsw-filters--right js-filters">
<div class="nsw-filters__controls js-filters--count">
<div class="nsw-filters__controls js-filters--count" aria-label="Search the site">
<button>
<span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">tune</span>
<span>Filters</span>
Expand All @@ -105,7 +105,7 @@ model:
</div>
<div class="nsw-filters__wrapper">
<div class="nsw-filters__back">
<button class="nsw-icon-button nsw-icon-button--flex js-close-sub-nav" type="button" aria-expanded="true">
<button type="button" class="nsw-icon-button nsw-icon-button--flex js-close-sub-nav" aria-expanded="true">
<span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">close</span>
<span class="sr-only">Close filters</span>
</button>
Expand Down Expand Up @@ -153,10 +153,10 @@ model:
</div>
</div>
<div class="nsw-filters__accept">
<button type="submit" class="nsw-button nsw-button--dark nsw-button--full-width">Apply filters</button>
<button type="submit" class="nsw-button nsw-button--dark nsw-button--full-width" aria-label="Apply filters">Apply filters</button>
</div>
<div class="nsw-filters__cancel">
<button type="reset">Clear all filters</button>
<button type="reset" aria-label="Clear all filters">Clear all filters</button>
</div>
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/templates/map/location-only.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ model:
<label class="nsw-form__label" for="form-postcode">Search by postcode</label>
<div class="nsw-form__input-group">
<input class="nsw-form__input" type="text" id="form-postcode" name="postcode" value="">
<button class="nsw-button nsw-button--dark nsw-button--flex" type="submit">Search</button>
<button type="submit" class="nsw-button nsw-button--dark nsw-button--flex" aria-label="Search for address by postcode">Search</button>
</div>
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs">
<a href="#" class="nsw-link nsw-link--icon nsw-m-top-xs" aria-label="Use my current location">
<span class="material-icons nsw-material-icons" focusable="false" aria-hidden="true">near_me</span>
<span>Use my currrent location</span>
</a>
Expand Down