Add typings #476
Merged
Add typings #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitneyit
force-pushed
the
feature/add-typings
branch
from
9990e00 to
a14970d
Compare
|
Hi, It appears that there is a problem with the authentication when deploying to staging? |
|
Hi @whitneyit - the action that is failing is relating to the staging env not authorising your user for staging only. Going to merge this today. As from your email that you had sent through, thank you for reaching out and for submitting the pull request - we really appreciate the initiative you’ve taken to address the issues with TypeScript support and the entry point exports in the NSW Design System. |
|
Thank you @oisa for merging this in 😄 |
|
You're most welcome @whitneyit - thanks so much for being part of the NSW Design System and for offering up your suggestions to make the design system better for all :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs adds support for TypeScript typings to be generated alongside the existing
starterkit:buildcommand.Also, this PR updates the entry point in
package.jsonto the correct value ofdist/js/main.jsas opposed to the current, incorrect, value ofdist/main.jswhich does not exist.