feat(schema): add draft-07 compatible app schemas for legacy validators #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you @ssaengs for the feedback!
This PR has been updated to automate the generation of backward-compatible
draft-07JSON schemas directly from the source Go structs, as you suggested.Implementation
I've modified the
spec/generate.goscript to produce the new schemas. This ensures that they will always remain in sync with thegodotype definitions and resolves the original validator bug in IDEs like VS Code.A Note on CI and
go generateWhile working on this, I discovered several pre-existing dependency issues with the project's global
go generate ./...command (specifically with themarketplacegenerator).To keep this PR focused, I ran the
spec/generate.goscript directly to generate the necessary files. The changes in this PR are self-contained and fully resolve the schema validation issue. Any potential CI failures from other, unrelated generator scripts are due to those pre-existing issues.Fixes issue #93