Update for k8s 1.31 #589
Update for k8s 1.31 #589
Conversation
d-honeybadger
commented
Aug 15, 2024
•
d-honeybadger
commented
- updated k8s dependencies and e2e tests to accomodate v1.31
- dropped 1.27
- updated go to 1.23
- updated various packages that dependabot had PRs for
- updated versions of kubernetes-csi components
- pulled in new volumesnapshot CRDs and updated the webhook b/c external-snapshotter had a breaking change
d-honeybadger
force-pushed
the
dkomsa/k8s-1.31-updates
branch
from
dcd9209 to
7759d04
Compare
external-snapshotter Since v8.0.0 of external-snapshotter, > The validating logic for VolumeSnapshots, VolumeSnapshotContents, VolumeGroupSnapshots, and VolumeGroupSnapshotContents has been replaced by CEL validation rules. https://github.com/kubernetes-csi/external-snapshotter/blob/v8.0.0/CHANGELOG/CHANGELOG-8.0.md Updated our crds to pull in those CEL validation rules and updated the webhook configuration to only act on snapshotclasses.
| @@ -167,7 +167,7 @@ Summaries: | |||
| fmt.Println("Stopping container") | |||
| // A nil timeout means we use the timeout configured on the container | |||
| // Config. | |||
| err := cli.ContainerStop(context.Background(), cont.ID, nil) | |||
| err := cli.ContainerStop(context.Background(), cont.ID, container.StopOptions{}) | |||
There was a problem hiding this comment.
b/c of docker pkg update
| @@ -20,9 +20,9 @@ webhooks: | |||
| - name: "validation-webhook.snapshot.storage.k8s.io" | |||
There was a problem hiding this comment.
Since v8.0.0, snapshot-validation-webhook doesn't validate anything but volumesnapshotclasses. New example configuration here: https://github.com/kubernetes-csi/external-snapshotter/blob/v8.0.1/deploy/kubernetes/webhook-example/admission-configuration-template
And here's the changelog entry: https://github.com/kubernetes-csi/external-snapshotter/blob/master/CHANGELOG/CHANGELOG-8.0.md#urgent-upgrade-notes
| @@ -20,9 +20,9 @@ webhooks: | |||
| - name: "validation-webhook.snapshot.storage.k8s.io" | |||
| rules: | |||
| - apiGroups: ["snapshot.storage.k8s.io"] | |||
| apiVersions: ["v1", "v1beta1"] | |||
There was a problem hiding this comment.
Changed to match the current example for this webhook configuration, but also v1beta1 was removed from webhook in v6.0.0: kubernetes-csi/external-snapshotter#709, so no point in keeping it here
| @@ -27,9 +27,8 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
There was a problem hiding this comment.
Copied new CRDs from https://github.com/kubernetes-csi/external-snapshotter/tree/v8.0.1/client/config/crd
Important change here is that they moved validation from the webhook to the CEL rules on the CRDs themselves, so I'm pulling in all that validation.
They've also added crds for "volumegroupsnapshots" but that's irrelevant for DO cause DO volumes don't support taking a snapshot of multiplt volumes at once
|
👋 do we have a newer version of csi-node-driver-registrar:v2.10.1? |
Looks like I missed that one, thank you! Updated it too, double-checked other images (that they're updated) |
