Add a firewall rule to open the LB health check and service port(s) when using service.beta.kubernetes.io/do-loadbalancer-type=REGIONAL_NETWORK
#748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbassingthwaite
force-pushed
the
bbass/LBAAS-3367/fw
branch
from
d6e5dbe
to
11f9467
Compare
…ice.beta.kubernetes.io/do-loadbalancer-type=REGIONAL_NETWORK`
bbassingthwaite
force-pushed
the
bbass/LBAAS-3367/fw
branch
from
11f9467
to
68a89fc
Compare
timoreimann
reviewed
Jul 26, 2024
| } else if svc.Spec.Type == v1.ServiceTypeLoadBalancer { | ||
| lbType, err := getType(svc) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
Can we add fmt.Errorf() around err to provide context, specifically the name of the Service affected?
Similar for the error returned in line 323.
| fwReq, err := fm.createReconciledFirewallRequest(test.serviceList) | ||
|
|
||
| if (err != nil && test.expectedError == nil) || (err == nil && test.expectedError != nil) { | ||
| t.Errorf("incorrect firewall config\nwant: %#v\n got: %#v", test.expectedError, err) |
There was a problem hiding this comment.
This should probably say
t.Fatalf("expected error %q, got %q", test.expectedError, err)
timoreimann
previously approved these changes
Jul 26, 2024
timoreimann
reviewed
Jul 26, 2024
| var nodePortInboundRules []godo.InboundRule | ||
| healthCheckPorts := make(map[int]struct{}) | ||
| for _, svc := range serviceList { | ||
| managed, err := isManaged(svc) |
There was a problem hiding this comment.
We may need to scope the non-management restriction down to the NodePort logic while continuing to reconcile ports for NLBs.
Withdrawing approval for now so that we don't forget.
timoreimann
dismissed
their stale review
annotation to disable firewall management may still need re-scoping
…b dataplane to arrive on the worker nodes.
bbassingthwaite
changed the title
service.beta.kubernetes.io/do-loadbalancer-type=REGIONAL_NETWORKservice.beta.kubernetes.io/do-loadbalancer-type=REGIONAL_NETWORK
timoreimann
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since NLB will route traffic over the public interface for both the LB data plane and health checks, we will need to open the appropriate health check port. This change only affects LBs who set the annotation
service.beta.kubernetes.io/do-loadbalancer-type=REGIONAL_NETWORKand the network isEXTERNAL(default).