migrate to instances v2 #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varshavaradarajan
force-pushed
the
varsha/migrate-to-instances-v2
branch
from
bd318e6
to
0805a4c
Compare
| return "", err | ||
| } | ||
| // cloudprovider.InstancesV2 methods | ||
| // InstancesV2 require ProviderID to be present, so the interface methods all use providerID to get droplet. |
|
|
||
| return nil, cloudprovider.InstanceNotFound |
There was a problem hiding this comment.
Ah, I need to handle this in InstancesV2
There was a problem hiding this comment.
Handled, with a note that returning false with no error from InstanceExists will remove the node from the cluster. We return nil error if godo err response is http.StatusNotFound.
gottwald
approved these changes
Nov 21, 2024
|
Will merge this, cause dev image to be released, will run the iteration e2e tests with the dev image and release CCM is all goes well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.