Add CA cert information to the credentials secret #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the self-signed CA cert is required to properly secure some database connections, include the cert information in the credentials secret. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
adamwg
suggested changes
Apr 27, 2023
There was a problem hiding this comment.
Thanks for the contribution!
This implementation looks good. Could you please update the tests to validate that the CA cert is populated? I don't think we need any new test cases here, just additional validation where we currently check the contents of the credential secret.
|
will we see this live eventually? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the self-signed CA cert is required to properly secure some database connections, include the cert information in the credentials secret.
Addresses #40