Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm before delete droplet #109

Closed
colkito opened this issue Jul 20, 2016 · 6 comments
Closed

Confirm before delete droplet #109

colkito opened this issue Jul 20, 2016 · 6 comments

Comments

@colkito
Copy link

colkito commented Jul 20, 2016

Feature request: We need a confirmation before delete (or any other critical action) a droplet. 😰

@snoopdouglas
Copy link
Contributor

#110 - pull request for this appears to have gone cold

@xmudrii
Copy link
Contributor

xmudrii commented Oct 4, 2016

@bryanl I don't think it is polite to original author, but can someone of us take on this problem? It it already more than 2 months from last activity on #110.
I could do it, make it working and possibly add it to more locations (like deleting volumes, images, etc).

I was also thinking about, something in lines of assume-yes config. If it is set to true in cfg file, you will not be asked for confirmation (doctl will work in mode like it is now). Maybe it would not be bad for users who can live without it, or use doctl in integration with other tools/scripts

@bryanl
Copy link
Contributor

bryanl commented Oct 4, 2016

@xmudrii I don't think it would be impolite seeing as #110 has gone code for a while. The only requirement from my point of view would be to ensure it works in interactive and non-interactive settings (eg. in a script and triggered with a flag). As for the configuration item, let's revisit that in a second PR. Personally, I have no problem with it, but I would like to float the idea internally as well.

@colkito
Copy link
Author

colkito commented Oct 4, 2016

Sorry for my delay! but at the moment I'm overloaded of work and sadly my free time to learn more about GO is very little...
If somebody can finish my PR could be great!
we are all agree about this requested feature, right?
greetings!

@xmudrii
Copy link
Contributor

xmudrii commented Oct 4, 2016

@colkito
Not a problem, I will have soon a first version on it so will make PR for @bryanl to check if is it ok for now. :)

bryanl added a commit that referenced this issue Oct 10, 2016
[Fixs #109] Adding confirmation on delete actions
@xmudrii
Copy link
Contributor

xmudrii commented Dec 7, 2016

@aybabtme @nanzhong I think you can close this, I fixed this in #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants