Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --wait flag to databases resize command #1585

Closed
loosla opened this issue Sep 25, 2024 · 3 comments
Closed

Add --wait flag to databases resize command #1585

loosla opened this issue Sep 25, 2024 · 3 comments

Comments

@loosla
Copy link
Contributor

loosla commented Sep 25, 2024

What is the problem this feature would solve? Please describe.
doctl aims to be useful in scripting. One way it does this is by providing a --wait flag for long running, async operations to block until they are complete rather than making the user implement polling in their own script. Some examples include:

  • doctl database create --wait
  • doctl compute droplet create --wait
  • doctl kubernetes cluster create --wait
  • doctl apps create --wait

Currently the doctl databases resize command does not have a --wait flag.

Describe the solution you'd like
Add a --wait flag to the doctl databases resize command. It should poll the /v2/databases/$DATABASE_ID/resize, blocking until the database cluster's status attribute moves from resizing to online.

Additional context
Following the code path starting here demonstrates how doctl database create's --wait flag is implemented:

if wait {

@Yordaniss
Copy link
Contributor

Hello @loosla This one sounds interesting. Can you please assign this issue to me? 🙂 Thanks

@SkySingh04
Copy link
Contributor

This looks like a fun issue, Will be working on this!

@Yordaniss
Copy link
Contributor

Hey @SkySingh04 sorry i already started working on this and already created a PR ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants